-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat - new search react component #2261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major nit I have is that it should show the title then, subsequently, the highlights below it. If the title is in the chunk_html then it should be removed as well. I would look for children matching the title text and remove those then mark the title as highlighted. But also maybe don't remove? I'm not sure, should study how Mintlify does it.
I think we should highly prioritize setting up chat for this as well |
The highlights should be much better now and will work on chat tomorrow |
3364057
to
d07ad8a
Compare
d07ad8a
to
d732771
Compare
d732771
to
32535fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. Definitely a fully functional component for search and I'm hype about it. Arrows and everything work and the display looks great.
Sorry for being pedantic with the commit history, but I'm nervous our total commit count is getting too large and makes us seem sus lol. Hype about this!
Example: https://trieve-react-search.surge.sh/