bugfix: highlightstrategy is now correctly present in URL params such…

… that it's sticky
devflowinc · Jul 29, 2024 · 5c24558 · 5c24558
1 parent 0403adb
commit 5c24558
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/frontends/search/src/components/ResultsPage.tsx b/frontends/search/src/components/ResultsPage.tsx
@@ -186,7 +186,7 @@ const ResultsPage = (props: ResultsPageProps) => {
         page_size: props.search.debounced.pageSize ?? 10,
         get_total_pages: props.search.debounced.getTotalPages ?? false,
         highlight_results: props.search.debounced.highlightResults ?? true,
-        highlight_strategy: props.search.debounced.highlightStrategy ?? false,
+        highlight_strategy: props.search.debounced.highlightStrategy ?? "v1",
         highlight_threshold: props.search.debounced.highlightThreshold,
         highlight_delimiters: props.search.debounced.highlightDelimiters ?? [
           "?",

diff --git a/frontends/search/src/components/SearchForm.tsx b/frontends/search/src/components/SearchForm.tsx
@@ -853,9 +853,9 @@ const SearchForm = (props: { search: SearchStore; groupID?: string }) => {
                                   },
                                   pageSize: 10,
                                   getTotalPages: false,
+                                  highlightStrategy: "v1",
                                   highlightResults: true,
                                   highlightDelimiters: ["?", ".", "!"],
-                                  highlightStrategy: "v1",
                                   highlightMaxLength: 8,
                                   highlightMaxNum: 3,
                                   highlightWindow: 0,

diff --git a/frontends/search/src/hooks/useSearch.ts b/frontends/search/src/hooks/useSearch.ts
@@ -89,6 +89,7 @@ const fromStateToParams = (state: SearchOptions): Params => {
     sort_by: JSON.stringify(state.sort_by),
     pageSize: state.pageSize.toString(),
     getTotalPages: state.getTotalPages.toString(),
+    highlightStrategy: state.highlightStrategy,
     highlightResults: state.highlightResults.toString(),
     highlightThreshold: state.highlightThreshold.toString(),
     highlightDelimiters: state.highlightDelimiters.join(","),