Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure $PROJECT_SOURCE and $PROJECT_ROOT are first environment variables in workspace containers #1282

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: Ensure $PROJECT_SOURCE and $PROJECT_ROOT are first environment variables in workspace containers #1282

merged 2 commits into from
Jul 3, 2024

Commits on Jun 28, 2024

  1. fix: allow devfile env vars to reference $PROJECT_SOURCE & $PROJECT_ROOT 

    Environment variables defined in a kubernetes container can only
reference other environment variables that are declared earlier in the
list of container environment variables.

This change ensures that the $PROJECT_SOURCE and $PROJECT_ROOT
devfile environment variables are the first environment variables
defined in all workspace pod containers so that devfile environment
variables can reference $PROJECT_SOURCE and $PROJECT_ROOT.

Fix devfile#1274

Signed-off-by: Andrew Obuchowicz <[email protected]>
    @AObuchow
    AObuchow committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ae31bc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. chore: add tests for ensuring project source and root are first env vars 

    Signed-off-by: Andrew Obuchowicz <[email protected]>
    @AObuchow
    AObuchow committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    26b9f18 View commit details
    Browse the repository at this point in the history