fix: don't abort PVC size calculation early if volume size not defined #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following rules are supposed to be used when computing the per-workspace PVC size:
Prior to this PR, rule 3 was not being respected in cases where a volume did not define its size, but later volumes (in the volume array) did define their sizes.
This commit prevents aborting the PVC size calculation too early, and modifies the test case that was relevant to rule 3 to ensure the case from #1162 is accounted for.
What issues does this PR fix or reference?
Fix #1162
Is it tested? How?
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che