-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple auth method support #19
base: master
Are you sure you want to change the base?
Multiple auth method support #19
Conversation
Asynchronous tests need to run the 'done' function supplied as their argument; otherwise they are considered passing prematurely.
parseAuth expects a full WWW-Authenticate header value which includes the scheme, so it makes sense to provide it in tests.
Clients should choose the safer alternative among the supported auth methods, which, in the case both Basic and Digest are offered, is Digest.
Split WWW-Authenticate by challenge and handle digest-related properties only for digest method.
Pull Request Test Coverage Report for Build 66
💛 - Coveralls |
Thanks. I will look into it later |
I think this would fix a problem I have in that if the server asks for basic auth, but we don't know ahead of time that basic auth is required, then this library is making a request with an authorization header like this:
So, without this PR, it will be necessary to try with |
Split WWW-Authenticate by challenge and handle digest-related properties only for digest method. Add tests to make sure Digest is chosen as the more secure variant.