feat(ui-library): made ids optional and provided fallback #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidken91
reviewed
Nov 23, 2023
| // the bitwise OR replaces Math.floor which is much faster, | ||
| // but will fail on very large numbers, which is not the case here | ||
| if (validFirstChar) { | ||
| return characters.charAt((Math.random() * validFirstCharactersLength) | 0); |
There was a problem hiding this comment.
Can I assume that the first character can never be a number which is why you have this check in place?
There was a problem hiding this comment.
yes, exactly.- according to specs, it has to start with letters.
there are more characters allowed here actually (dash for example) but its fine like this i guess
There was a problem hiding this comment.
code was from stackover flow bad had that issue, i just optimized it and fixed it
davidken91
reviewed
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.