Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish checkbox #636

Closed
wants to merge 11 commits into from
Closed

Finish checkbox #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
edab070
fixed has error checked state
ChristianHoffmannS2 Nov 20, 2023
e79dec2
restructured css
ChristianHoffmannS2 Nov 21, 2023
990b818
fix: renames checkbox config tokens
larserbach Nov 21, 2023
2a6fbd9
most cases are working
ChristianHoffmannS2 Nov 21, 2023
40159d0
checker icons can be defined via attributes
ChristianHoffmannS2 Nov 21, 2023
f560c83
icons are sized well now
ChristianHoffmannS2 Nov 21, 2023
efffb19
handle key, click and touches
ChristianHoffmannS2 Nov 22, 2023
d15e67b
basic focus ring
ChristianHoffmannS2 Nov 22, 2023
cec78e1
keyboard events are working
ChristianHoffmannS2 Nov 22, 2023
0f97da3
finished
ChristianHoffmannS2 Nov 22, 2023
8dd0032
fix(ui-library): removed logs and made chckbox work with left click o…
ChristianHoffmannS2 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/figma-design-tokens/input/tokens/$themes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3239,4 +3239,4 @@
"🔷 ErrorMsg": "c53a483d2440f5df0047daa2e6da82e2c610b3a8"
}
}
]
]
54 changes: 24 additions & 30 deletions packages/figma-design-tokens/input/tokens/sizeVariants/CMP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,57 +207,51 @@
}
}
},
"Forms": {
"Checkbox": {
"SM": {
"Control": {
"Navigation": {
"TabBar": {
"Tab": {
"SM": {
"Icon": {
"value": "SM",
"value": "XS",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
}
},
"MD": {
"Control": {
},
"MD": {
"Icon": {
"value": "SM",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
}
},
"LG": {
"Control": {
},
"LG": {
"Icon": {
"value": "MD",
"value": "SM",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
}
}
}
},
"Navigation": {
"TabBar": {
"Tab": {
"SM": {
"Icon": {
"value": "XS",
}
},
"Forms": {
"Checkbox": {
"Control": {
"Icon": {
"SizeVariant": {
"SM": {
"value": "SM",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
},
"MD": {
"Icon": {
},
"MD": {
"value": "SM",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
},
"LG": {
"Icon": {
"value": "SM",
},
"LG": {
"value": "MD",
"type": "componentConfig",
"description": "Defines which size-variant of the Icon Component should be used. (The default dimensions might be overrridden with a sizing token.)"
}
Expand Down
Loading
Loading