Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): pressed state removed and updated focus state for readonly #1172

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ashk1996
Copy link
Contributor

@ashk1996 ashk1996 commented Nov 6, 2024

closes #1155
closes #1125

…ly-for-select-textarea-inputfieldtext-inputfieldnumber
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ashk1996 ,
here are my findings:

#1155 :

  • Could we update the input field text, so that the focus ring gets applied as soon as I press down the mouse button? Currently it will only get applied once I release the button (for all other components its working this way already)
  • The Input Field hover state when hasError=true looks different than in design (both in dark and light mode) it should look the same as the rest state. Also the focus state is not dominating this state.

#1125 :

  • Focusing a readonly Text Area component via a Tab / via keyboard navigation, does not select the value (for input field text and input field number this works).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants