Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): #1153 switch to DTCG token format & migrate to latest styledictionary and ts-transform #1160

Merged
merged 14 commits into from
Oct 2, 2024

Conversation

larserbach
Copy link
Contributor

@larserbach larserbach commented Sep 25, 2024

Switched from token legacy fomat to DTCG format

  • this means, token-properties 'type', 'value' and 'description' are prefixed with a dollar sign ('$')

Updates our tokens build-pipeline

  • updated dependencies:

    • storybook v.4.0.0
    • ts-transforms v1.0.0
  • updates style-dictionary.config

    • resolving breaking changes resulting from new Style Dictionary API
    • dynamically generating theme-names now from tokens/$themes.json. This prepares us to handle multidimensional themes better in the future. This also means, that our generated token files have changed names.
      -removed ../pckg/figma-design-tokens/config/themes.cjs now generating ../pckg/figma-design-tokens/config/themes_generated.cjs
  • removes ../pckg/figma-design-tokens/config/transforms/...

    • instead we use the transforms from the @token-studio package, one single custom transform has moved into style-dictionary.config.mjs

Updates all index.ts files
@property() accessor theme: ThemeType = 'Light'; -> @property() accessor theme: ThemeType = 'Light_value';

Not related, but did it anyways:

  • removed: foundation/component-tokens/radio.css.ts
  • added the radio/index.css.ts
  • updated radio-group/index.css.ts

@larserbach larserbach added the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Sep 25, 2024
@larserbach larserbach linked an issue Sep 25, 2024 that may be closed by this pull request
2 tasks
@larserbach larserbach changed the title fix(all):#1153 switch to DTCG token format and migrate to latest styledictionary and ts-transform version fix(all): #1153 switch to DTCG token format and migrate to latest styledictionary and ts-transform version Sep 25, 2024
@larserbach larserbach changed the title fix(all): #1153 switch to DTCG token format and migrate to latest styledictionary and ts-transform version fix(all): #1153 switch to DTCG token format & migrate to latest styledictionary and ts-transform Sep 25, 2024
@larserbach larserbach merged commit 6f91b28 into develop Oct 2, 2024
4 of 5 checks passed
@larserbach larserbach deleted the fix/#1153-convert-tokens-to-new-format branch October 2, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert tokens to W3C DTCG format
1 participant