Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): Input field number adjustment #1152

Merged
merged 13 commits into from
Oct 14, 2024

Conversation

bar-tay
Copy link
Contributor

@bar-tay bar-tay commented Sep 2, 2024

closes #915
closes #932
closes #933
closes #1117

@bar-tay bar-tay changed the title fix(storybook): state issues fix(storybook): Input field number adjustment Sep 3, 2024
@bar-tay bar-tay added the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Sep 3, 2024
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bar-tay , here are my findings:

#933

  • The unit color is not correct in disabled and in error state

#932

  • The widths are all correct now, but it seems like the height in the MD is wrong now for the vertical stepper variant

#915

  • When a unit is shown or when stepperVaraint = Split, the readonly state now shows some outline or border around the user input container

Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bar-tay , everything has been solved :-)

@thrbnhrtmnn thrbnhrtmnn merged commit fc5fa4a into develop Oct 14, 2024
4 of 5 checks passed
@thrbnhrtmnn thrbnhrtmnn deleted the fix/915_input-number-fix branch October 14, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers
Projects
None yet
4 participants