Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump CI versions #1082

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,36 +3,24 @@ name: Node CI
on:
pull_request: {}
push:
branches-ignore:
- trying.tmp
- staging.tmp
branches:
- master
Comment on lines -6 to +7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting to master else a PR gets a CI run from both push and & pull_request triggers


jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [18.x, 20.x]

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Cache node modules
uses: actions/cache@v1
env:
cache-name: cache-node-modules
with:
path: ~/.npm
# This uses the same name as the build-action so we can share the caches.
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-build-${{ env.cache-name }}-
${{ runner.os }}-build-
${{ runner.os }}-
cache: npm
- run: npm ci --ignore-scripts
- name: npm build and test
run: npm test
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@master
uses: actions/checkout@v4
with:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0

- name: Setup Node.js 12.x
uses: actions/setup-node@master
- name: Setup Node.js 18.x
uses: actions/setup-node@v4
with:
node-version: 12.x
node-version: 18.x

- name: Install Dependencies
run: npm install
Expand Down
9 changes: 1 addition & 8 deletions .github/workflows/size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,11 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: compressed-size-action
uses: preactjs/compressed-size-action@v2
with:
pattern: 'dist/!(*.js.map)'
build-script: build
repo-token: '${{ secrets.GITHUB_TOKEN }}'

- name: compressed-size-action
uses: preactjs/compressed-size-action@v2
with:
pattern: 'test/fixtures/**/dist/!(*.map)'
build-script: 'test'
repo-token: '${{ secrets.GITHUB_TOKEN }}'
Comment on lines -19 to -25
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that this is particularly useful, any size difference will be accounted for in the tests already.

Loading
Loading