feat: Add MultiSelect widget to chatmark library #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement MultiSelect class in widgets.py - Update __init__.py to export MultiSelect - Add support for multiple option selection with checkboxes
kagami-l
requested changes
Nov 14, 2024
lib/chatmark/widgets.py
Outdated
| @@ -162,6 +162,94 @@ def _parse_response(self, response: Dict): | |||
|
|
|||
| self._selections = selections | |||
|
|
|||
| class multiSelect(Widget): | |||
There was a problem hiding this comment.
类名首字母要大写
然后python这边只是chatmark语法里的符号不一样、其他逻辑一样，可以写成CheckBox的子类、只重写_in_chatmark函数
- Rename multiSelect class to MultiSelect for consistency - Inherit MultiSelect from Checkbox to reduce code duplication - Remove redundant properties and methods in MultiSelect class
kagami-l
approved these changes
Nov 14, 2024
- Implement MultiSelect widget inheriting from Checkbox - Update import order in __init__.py for consistency - Prepare groundwork for multi-select dropdown functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new MultiSelect widget to the chatmark library. The changes include:
These additions will enhance the functionality of the chatmark library by providing users with a multi-select option capability.