Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devchat): correct update_custom_workflows return statements #414

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

runjinz
Copy link

@runjinz runjinz commented Sep 10, 2024

Correct the return statement in update_custom_workflows to explicitly pass False for the updated field and provide a clearer message for the message field. This change ensures consistent return type and improves the readability of the status messages.

@runjinz runjinz requested a review from kagami-l September 10, 2024 08:30
Rankin Zheng and others added 3 commits September 23, 2024 09:48
Correct the return statement in `update_custom_workflows` to explicitly pass `False` for
the `updated` field and provide a clearer message for the `message` field. This change
ensures consistent return type and improves the readability of the status messages.
Update the clone process for custom git repositories by utilizing the specific branch
information supplied in the workflow configuration. This change allows for more flexible
and accurate repository management compared to the previous hardcoded approach.
@kagami-l kagami-l force-pushed the fix-not-found-custom_git_urls branch from fa5b440 to 97aae00 Compare September 23, 2024 01:50
@kagami-l kagami-l merged commit ef59342 into main Sep 23, 2024
2 checks passed
@kagami-l kagami-l deleted the fix-not-found-custom_git_urls branch September 23, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants