Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

20 add popups handling #117

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

20 add popups handling #117

wants to merge 6 commits into from

Conversation

JelenaRy
Copy link
Collaborator

  • Added 2 functions to Helpers class to handle popups
  • Added tests to helpers.test.js
  • Updated Element class to contain page property (uses global page by default)
  • Updated Interceptor class to contain page property (uses global page by default)
  • Updated tests in interceptor.test.js to use added page property
  • Updated selector in one of tests in elementActions.test.js

@JelenaRy JelenaRy linked an issue May 28, 2021 that may be closed by this pull request
Copy link
Collaborator

@vaidasmaciulis vaidasmaciulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge latest master to branch

@@ -2,23 +2,30 @@ import { Element, Interceptor } from "test-juggler";

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 tests are failing in interceptor suite:

  Interceptor
    √ should block requests by any url fragment using Regex pattern while test case running (7423 ms)
    √ should block requests by any url fragment using Glob pattern after abort method is used (3831 ms)
    √ should block request by any url fragment after action (3455 ms)
    × should block any request after action (30176 ms)
    √ should count all requests (368 ms)
    × should detect specific response after action (30182 ms)
    × should detect any request after action (3 ms)


//Act
await pageWithDismissAlertsSetup.goto("http://the-internet.herokuapp.com/javascript_alerts");
await pageWithDismissAlertsSetup.click("button[onclick='jsAlert()']");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two lint issues:
C:\source\test-juggler\example\tests\helpers.test.js
107:1 error Mixed spaces and tabs no-mixed-spaces-and-tabs
122:1 error Mixed spaces and tabs no-mixed-spaces-and-tabs

✖ 2 problems (2 errors, 0 warnings)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle popups/alerts
3 participants