Make idb_sys::Transaction Clone

[Ekleog]

This is more convenient for downstream users than having to cast to web_sys::IdbTransaction and back every time they want to clone.

[Ekleog]

Looks like CI is pretty broken, none of the changes seem related to my changes 😅

[devashishdxt]

Looks like CI is pretty broken, none of the changes seem related to my changes 😅

I don't think that the CI is broken. These changes are related to CI failure. When you don't store the closures in the IdbTransaction struct, they gets dropped after that function completes. It is necessary to keep those closures in memory until the transaction is dropped.

[devashishdxt]

Removing this will drop the closure from memory once this function completes. This may lead to undefined behaviour.

[Ekleog]

Good, point, thank you! Seeing the lints fail on code I didn't touch, I assumed that the index read was also a spurious failure, sorry 😅

I was actually coming back to this PR to close it myself after noticing my mistake. However, I'll argue that the current code does not actually work properly anyway: it means that one cannot call .on_success() from a .on_success() handler, which in turns means that the IndexedDb API is basically impossible to use properly for multi-requests transactions. That said I'm still trying to think of a good fix, and will come back to you if I find one :)

BTW, if you're up, can you have a look at #7 (comment)? It's not impossible I'll ragequit trying to use idb-sys manually tomorrow, in which case I'd likely start implementing something like what I described there, and it'd be great if I knew whether to implement it in my own code or in idb itself :)

[Ekleog]

Let's close this PR, I opened #17 to track the related issue