fix mod_alias icon path

[timogoebel]

Currently mod_alias icons template is broken, because $icons_path is not in the scope of puppetlabs.pp, but puppet uses this scope in the resource collector overwriting the config file.

This PR pulls the variable into the correct scope and exchanges the template to the original one as there is a way to apply the hardening with the current upstream version.

This is, what happens when you apply the patched module:

Notice: /Stage[main]/Apache::Mod::Alias/File[alias.conf]/content:
--- /etc/httpd/conf.d/alias.conf    2015-10-27 16:33:58.233185975 +0100
+++ /tmp/puppet-file20151028-7080-cl5c6n    2015-10-28 08:40:53.526364470 +0100
@@ -1,8 +1,8 @@
 <IfModule alias_module>
-Alias /icons/ "/"
-<Directory "">
+Alias /icons/ "/usr/share/httpd/icons/"
+<Directory "/usr/share/httpd/icons">
     Options -Indexes +MultiViews -FollowSymLinks
     AllowOverride None
     Require all granted
 </Directory>
-</IfModule>
\ No newline at end of file
+</IfModule>

[tuxmea]

Is this issue still open?

[timogoebel]

@tuxmea : I guess, this issue still applies. I stopped using this project though as it seems unmaintained and I don't think overwriting stuff via own templates is the best way to go. So I can't say for sure.