Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail disabled kernel module checks if the modules aren't installed #149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Don't fail disabled kernel module checks if the modules aren't installed #149

wants to merge 4 commits into from

Conversation

bendres97
Copy link
Contributor

Fixes #148

schurzi
schurzi requested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach seems good, I will have to test this once the comments are adressed

controls/1_1_filesystem_configuration.rb Show resolved Hide resolved
controls/1_7_warning_banners.rb Outdated Show resolved Hide resolved
@bendres97 bendres97 requested a review from schurzi March 29, 2023 23:39
@justdan96
Copy link

Is this okay to be merged now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schurzi schurzi Awaiting requested review from schurzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kernel checks fail when the kernel module doesn't exist
3 participants
@bendres97 @justdan96 @schurzi