Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only skip audit restart handler in docker #637

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

nejch
Copy link
Contributor

@nejch nejch commented Feb 15, 2023

Thanks again for this collection!

We use this as a dependency in our own lightweight wrapper hardening collection. We test some auditd rules, so we spin up proper vagrant or ec2 machines, and would like to run some verify tasks on them. But we need to run the auditd handler in order to see that rules are applied correctly.

This narrows down the when condition to only skip if the docker driver is present. Would this make sense? I can extend this if needed, maybe I missed a few other use cases.

/cc @dlouzan @bufferoverflow

@nejch
Copy link
Contributor Author

nejch commented Feb 15, 2023

@rndmh3ro
Copy link
Member

I like it! We cann now see if a restart would fail, so it improves our tests!

Thanks for the PR!

BTW:

We use this as a dependency in our own lightweight wrapper hardening collection. We test some auditd rules, so we spin up proper vagrant or ec2 machines.

We have plans to add support for auditd-rules (while providing some default rules). There's a rather old PR here but it's not forgotten. Would you be interested in this?

@rndmh3ro rndmh3ro merged commit 9e4ea20 into dev-sec:master Feb 15, 2023
@nejch
Copy link
Contributor Author

nejch commented Feb 15, 2023

We have plans to add support for auditd-rules (while providing some default rules). There's a rather old PR here but it's not forgotten. Would you be interested in this?

@rndmh3ro definitely, I saw that PR and was actually going to comment there to see if there's interest in it still. It would also significantly simplify our wrapper I think.

Just cc me there if there is any movement already otherwise I will get in touch as well :)

@nejch nejch deleted the test/audit-handler-docker branch February 15, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants