feat: [CGC-65] Automatic time interval selection #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petterav
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Weight for age shows 0-2 years even though the child is 3 years. This is because the keys are different for this particular indicator. Not a big issue, because this feature is just to help improve the efficieny, but it is also possible to create a scenario for this particular indicator.
Well done Edvin. The code works extremely good! Look at the comments and i will review again!
…omaticTimeIntervalSelection # Conflicts: # i18n/en.pot # src/components/GrowthChart/GrowthChart.tsx
petterav
reviewed
Aug 2, 2024
…omaticTimeIntervalSelection # Conflicts: # i18n/en.pot # src/Plugin.tsx
petterav
approved these changes
Aug 14, 2024
edvinstava
deleted the
eas/feat/CGC-65_AutomaticTimeIntervalSelection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the functionality of the growth chart plugin by selecting the appropriate time interval for the selected child's age by default.