feat: [CGC-34] Change to DHIS2 UI #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikmv
requested review from
petterav and
edvinstava
and removed request for
petterav
petterav
reviewed
Jun 12, 2024
cypress/component/ChartSelector/ChartSelectorDropdown/ChartSelectorDropdown.cy.js
Show resolved
Hide resolved
src/components/GrowthChart/GrowthChartBuilder/GrowthChartBuilder.tsx
Outdated
Show resolved
Hide resolved
src/components/GrowthChart/ChartSettingsButton/EllipsisButton/EllipsisButton.tsx
Outdated
Show resolved
Hide resolved
src/components/GrowthChart/ChartSettingsButton/EllipsisButton/EllipsisButton.tsx
Outdated
Show resolved
Hide resolved
edvinstava
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Well done Henrik, I just have 3 minor comments that you can take a look at. The dropdowns look great and generic! I will approve now as the requested changes are minor, but please take a look at my comments.
Additionally, I get some changes to the yarn.lock file for the branch when running "yarn". Make sure to run yarn and upload any possible changes to the yarn.lock file. Furthermore, if you can run "yarn start", it will update the en.pot file as well.
Well done!
src/components/GrowthChart/ChartSettingsButton/EllipsisButton/EllipsisButton.tsx
Show resolved
Hide resolved
src/components/GrowthChart/GrowthChartSelector/ChartSelectorDropdown/ChartSelectorDropdown.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGC-34
NOTE: This issue introduces a bug where the dropdown list goes upwards for Cypress testing. See bug issue here.
The workaround for now, is to use Force click.