feat: [CGC-46] Faciliate for Percentiles #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
petterav
commented
Mar 18, 2024
petterav
commented
- It is now possible to view the chart with percentiles
- This feature is just implemented in the code and not utilized
edvinstava
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Well done Petter! I noticed a problem for the percentile lines when choosing the Weight for length/height category. The annotation on the line end didn't work, and I got this console error: xAxisValues and dataSet should have the same length. Take a look at it and re request review.
src/Components/GrowthChart/GrowthChartBuilder/GrowthChartBuilder.tsx
Outdated
Show resolved
Hide resolved
henrikmv
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.