fix: review changes

dev-otta · Jun 19, 2024 · 82f9fc5 · 82f9fc5
1 parent fe06d63
commit 82f9fc5
Show file tree

Hide file tree

Showing 4 changed files with 730 additions and 36 deletions.
diff --git a/i18n/en.pot b/i18n/en.pot
@@ -5,8 +5,8 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"POT-Creation-Date: 2024-06-10T07:28:02.836Z\n"
-"PO-Revision-Date: 2024-06-10T07:28:02.836Z\n"
+"POT-Creation-Date: 2024-06-19T13:53:21.384Z\n"
+"PO-Revision-Date: 2024-06-19T13:53:21.384Z\n"
 
 msgid "Growth Chart"
 msgstr "Growth Chart"
@@ -46,6 +46,9 @@ msgstr "Year"
 msgid "Years"
 msgstr "Years"
 
+msgid "Gender is pre-selected based on the profile"
+msgstr "Gender is pre-selected based on the profile"
+
 msgid "Months"
 msgstr "Months"
 

diff --git a/src/components/GrowthChart/GrowthChart.tsx b/src/components/GrowthChart/GrowthChart.tsx
@@ -91,7 +91,7 @@ export const GrowthChart = ({
                     gender={gender}
                     setGender={setGender}
                 />
-                <div className='relativ'>
+                <div>
                     <ChartSettingsButton
                         category={category}
                         dataset={dataset}

diff --git a/...omponents/GrowthChart/GrowthChartSelector/ChartSelectorDropdown/ChartSelectorDropdown.tsx b/...omponents/GrowthChart/GrowthChartSelector/ChartSelectorDropdown/ChartSelectorDropdown.tsx
@@ -17,36 +17,38 @@ export const ChartSelectorDropdown = ({
     handleItemChange,
     isDisabled,
     dataTest,
-}: ChartSelectorDropdownProps) => {
-    const tooltipContent = i18n.t('Gender is pre-selected based on the profile');
-    return (
-        isDisabled ? (
-            <Tooltip openDelay={500} closeDelay={50} content={tooltipContent}>
-                <InputField
-                    value={title.toString()}
-                    disabled
-                    inputWidth='50px'
-                    dense
-                    data-test={`${dataTest}-disabled-button`}
-                />
-            </Tooltip>
-        ) : (
-            <SingleSelectField
-                className='cursor-pointer'
-                onChange={({ selected }) => handleItemChange(selected)}
-                selected={title.toString()}
+}: ChartSelectorDropdownProps) => (
+    isDisabled ? (
+        <Tooltip
+            openDelay={500}
+            closeDelay={50}
+            content={i18n.t('Gender is pre-selected based on the profile')}>
+
+            <InputField
+                value={title.toString()}
+                disabled
+                inputWidth='50px'
                 dense
-                dataTest={`${dataTest}-button`}
-            >
-                {items.map((item) => (
-                    <SingleSelectOption
-                        key={item}
-                        label={item}
-                        value={item}
-                        dataTest={`${dataTest}-item`}
-                    />
-                ))}
-            </SingleSelectField>
-        )
-    );
-};
+                data-test={`${dataTest}-disabled-button`}
+            />
+        </Tooltip>
+    ) : (
+        <SingleSelectField
+            className='cursor-pointer'
+            onChange={({ selected }) => handleItemChange(selected)}
+            selected={title.toString()}
+            dense
+            dataTest={`${dataTest}-button`}
+        >
+            {items.map((item) => (
+                <SingleSelectOption
+                    key={item}
+                    label={item}
+                    value={item}
+                    dataTest={`${dataTest}-item`}
+                />
+            ))}
+        </SingleSelectField>
+    )
+);
+