Added sorting to roles on the involvement section

finos#6770
deutschebank · Sep 17, 2023 · 08f1854 · 08f1854
1 parent 0b41dbf
commit 08f1854
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/waltz-ng/client/involvement/components/involved-people-section.html b/waltz-ng/client/involvement/components/involved-people-section.html
@@ -140,7 +140,7 @@
             </thead>
 
             <tbody>
-                <tr ng-repeat="role in row.entity.roles">
+                <tr ng-repeat="role in row.entity.roles | orderBy:'displayName'">
                     <td>
                         <div ng-bind="role.displayName"></div>
                         <div class="small text-muted" ng-bind="role.provenance"></div>

diff --git a/waltz-ng/client/involvement/components/involved-people-section.js b/waltz-ng/client/involvement/components/involved-people-section.js
@@ -50,11 +50,6 @@ const columnDefs = [
     {
         field: "rolesDisplayName",
         displayName: "Roles",
-        sortingAlgorithm: (a, b) => {
-            const aNames = _.join(_.map(a, "displayName"));
-            const bNames = _.join(_.map(b, "displayName"));
-            return aNames.localeCompare(bNames);
-        },
         cellTemplate: `
                 <div class="ui-grid-cell-contents">
                     <span ng-bind="COL_FIELD"
@@ -95,6 +90,7 @@ function mkGridData(involvements = [], displayNameService, descriptionService) {
             const rolesDisplayName = _
                 .chain(roles)
                 .map("displayName")
+                .sort()
                 .join(", ")
                 .value();