Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LogMaskedAttribute.GetMaskedValue #88

Closed
wants to merge 2 commits into from
Closed

Expose LogMaskedAttribute.GetMaskedValue #88

wants to merge 2 commits into from

Conversation

sungam3r
Copy link
Member

fixes #71

@nblumhardt Are you OK to make this method public?

@sungam3r sungam3r added the enhancement New feature or request label Jan 22, 2024
@github-actions github-actions bot added tests Pull request that adds new or changes existing tests and removed enhancement New feature or request labels Jan 22, 2024
@sungam3r
Copy link
Member Author

ping @juchom

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (912cacd) 93.57% compared to head (7e33797) 93.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   93.57%   93.57%           
=======================================
  Files          13       13           
  Lines         249      249           
  Branches       39       39           
=======================================
  Hits          233      233           
  Misses         10       10           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungam3r
Copy link
Member Author

Not needed.

@sungam3r sungam3r closed this Jan 25, 2024
@sungam3r sungam3r deleted the masked branch January 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a render masked string only method in IPropertyDestructuringAttribute
1 participant