Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LogWithNameAttribute on complex objects #110

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Fix LogWithNameAttribute on complex objects #110

merged 2 commits into from
Feb 27, 2024

Conversation

sungam3r
Copy link
Member

fixes #65

@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull request that adds new or changes existing tests labels Feb 27, 2024
@sungam3r sungam3r self-assigned this Feb 27, 2024
@sungam3r sungam3r added bugfix Pull request that fixes a bug and removed documentation Improvements or additions to documentation labels Feb 27, 2024
@sungam3r
Copy link
Member Author

@nblumhardt After merging this one I'll publish v4. Nothing to do for me her except #40 but as I said I don't think I will work on this feature.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd08cf8) to head (961d992).

❗ Current head 961d992 differs from pull request most recent head 460908c. Consider uploading reports for the commit 460908c to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          237       237           
  Branches        35        35           
=========================================
  Hits           237       237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungam3r sungam3r merged commit 6de06e7 into master Feb 27, 2024
4 checks passed
@sungam3r sungam3r deleted the logwithname branch February 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug tests Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using LogWithNameAttribute will Prevent the Property From Being Destructured
1 participant