forked from Netflix/concurrency-limits
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fork #1
Open
martinlocurcio
wants to merge
84
commits into
despegar:master
Choose a base branch
from
Netflix:main
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade nebula.netflixoss to replace bintray publication and update TravisCi secrets
Replace JCenter with Maven Central
Remove TravisCI and use Github Actions
Update gradle and dependency scopes.
Add configurable http status for throttled requests
If a token was acquired around the same time that an operation timed out, then the token would get lost. That means that the limiter's capacity would effectively be reduced by one. If this happens enough times, or the limit is decreased enough for other reasons, then this would cause to the limiter to permanently not let any operations through anymore.
An Optional field that can be null is unexpected.
Use a Semaphore in SimpleLimiter to manage access in a thread-safe manner. Fixes #140.
Fix race condition in LifoBlockingLimiter
don't drop by half periodically.
Use a counting semaphore in SimpleLimiter
preparation for future change
Remove unused imports and replace deprecated JUnit import
Prevent duplicate publishing on release
guarantees ordering visibility
added a comment to the predicate setup to discourage accessing limiter while inside predicate
…-limiter Reduce contention a little in AbstractPartitionedLimiter
Add two methods to SampleListener, addLongSample and addDoubleSample, which accept primitives and avoid boxing; default implementations are provided for backwards compatibility.
Use LongSupplier for clock in AbstractLimiter
Use IntUnaryOperator in Gradient2Limit for queueSize to avoid boxing. Also, avoid excessive volatile reads and avoid boxing when debug logging is disabled.
Return singleton no-op Listener in createBypassListener
Add methods to SampleListener to handle primitives
Use IntUnaryOperator in Gradient2Limit for queueSize
Switch to IntUnaryOperator and DoubleUnaryOperator in VegasLimit to avoid unnecessary boxing. Additionally, reduced repeated reads of volatile fields.
Use IntUnaryOperator / DoubleUnaryOperator in VegasLimit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.