Make Scintilla.NET compatible with C# 7.3 #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahmetsait What about the change makes you think it is not worth it? |
The sheer amount of pain for not being able to use any of the newer C# features just so few users can have the slight convenience of being able to build the project with an older .NET SDK version. I also realized Scintilla.NET was using C# 10 before I changed it to Okay so even though I did the work, I'm closing this because I convinced myself isn't a good direction for the project overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not really sure if this is worth merging. We can just set
<LangVersion>12.0</LangVersion>and tell people to use an up-to-date .NET SDK to build instead. What do you think @desjarlais?