Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlagsConverter tweaks & code cleanup #122

Merged
merged 6 commits into from
May 13, 2024
Merged

FlagsConverter tweaks & code cleanup #122

merged 6 commits into from
May 13, 2024

Commits on May 12, 2024

  1. Add missing docs & fix warnings

    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    3b7ffed View commit details
    Browse the repository at this point in the history

  2. Update .editorconfig

    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    34c2414 View commit details
    Browse the repository at this point in the history

  3. Delete Tuple.cs because System.Tuple exists

    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    1895ce3 View commit details
    Browse the repository at this point in the history

  4. Target net47 because System.ValueTuple doesn't exist in net462

    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    3b4e975 View commit details
    Browse the repository at this point in the history

  5. Tweak FlagsConverter so it produces smaller string representations … 

    …of the flag

Finding the smallest flag combination that completely encompasses a given value is actually NP-hard. See: https://en.wikipedia.org/wiki/Set_cover_problem
What we use here is a greedy O(N²) algorithm but the biggest integer is 64 bits so the worst case doesn't seem that bad.
    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    d9d082d View commit details
    Browse the repository at this point in the history

  6. Run code cleanup

    @ahmetsait
    ahmetsait committed May 12, 2024
    Configuration menu
    Copy the full SHA
    a836fcb View commit details
    Browse the repository at this point in the history