Template fft caching #180
Merged
Template fft caching #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always set to their defaults in the templates object
convolution we use in convolve_vdisp() on whether it is present. oaconvolve is faster without it, but fftconvolve is faster with. * cache template Fourier transforms to speed up vdisp convolution * make agekeep a null slice instead of an arange when it is equal to the whole array, since the latter causes an array copy when used in indexing, while the former does not. Provide nage because it cannot be inferred from a slice.
Pull Request Test Coverage Report for Build CI-828Details
💛 - Coveralls |
|
Thanks for this contribution @jdbuhler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more efficient handling of template FFTs. Use mkl_fft it if is present in the Python environment, and cache template FTs so that we can do convolve_vdisp faster. The code should gracefully fall back to reasonable behavior if mkl_fft is not present