Use OtlpJsonLoggingMetricExporter

Signed-off-by: Siddhant Deshmukh <[email protected]>
deshsidd · Aug 12, 2024 · f37a5fa · f37a5fa
1 parent 1e3bb88
commit f37a5fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 16 deletions.
diff --git a/...l/src/main/java/org/opensearch/telemetry/metrics/exporter/OTelMetricsExporterFactory.java b/...l/src/main/java/org/opensearch/telemetry/metrics/exporter/OTelMetricsExporterFactory.java
@@ -14,6 +14,7 @@
 import org.opensearch.common.settings.Settings;
 import org.opensearch.telemetry.OTelTelemetrySettings;
 
+import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
 import java.lang.reflect.Method;
@@ -66,10 +67,12 @@ private static MetricExporter instantiateExporter(Class<MetricExporter> exporter
                     }
                 }
                 try {
-                    return (MetricExporter) MethodHandles.publicLookup()
-                        .findStatic(exporterProviderClass, methodName, MethodType.methodType(exporterProviderClass))
-                        .asType(MethodType.methodType(MetricExporter.class))
-                        .invokeExact();
+                    MethodHandles.Lookup lookup = MethodHandles.publicLookup();
+                    MethodType methodType = MethodType.methodType(MetricExporter.class);
+
+                    // Look up the 'create' method with no parameters
+                    MethodHandle handle = lookup.findStatic(exporterProviderClass, methodName, methodType);
+                    return (MetricExporter) handle.invokeExact();
                 } catch (Throwable e) {
                     if (e.getCause() instanceof NoSuchMethodException) {
                         throw new IllegalStateException("No create factory method exist in [" + exporterProviderClass.getName() + "]");

diff --git a/.../test/java/org/opensearch/telemetry/metrics/exporter/OTelMetricsExporterFactoryTests.java b/.../test/java/org/opensearch/telemetry/metrics/exporter/OTelMetricsExporterFactoryTests.java
@@ -63,16 +63,4 @@ public void testMetricExporterNonMetricExporterClass() {
         assertTrue(exception.getCause() instanceof NoSuchMethodError);
 
     }
-
-    public void testMetricExporterGetDefaultMethod() {
-        Settings settings = Settings.builder()
-            .put(
-                OTelTelemetrySettings.OTEL_METRICS_EXPORTER_CLASS_SETTING.getKey(),
-                "io.opentelemetry.exporter.otlp.metrics.OtlpGrpcMetricExporter"
-            )
-            .build();
-
-        assertTrue(OTelMetricsExporterFactory.create(settings) instanceof OtlpGrpcMetricExporter);
-    }
-
 }