Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(webapp): migrate css deep operator #872

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 13, 2024

preparation for vue3
add eslint rule

@peterthomassen
Copy link
Member

Don't these need parentheses, like ::v-deep(...) instead of ::v-deep ...?

Also, there's now :deep(), but I guess that's only an option once we've actually migrated to Vue 3.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 2, 2024

Don't these need parentheses, like ::v-deep(...) instead of ::v-deep ...?

For vue2 I just found code examples without ().

Also, there's now :deep(), but I guess that's only an option once we've actually migrated to Vue 3.

Yes

Rotzbua and others added 3 commits February 5, 2024 14:43
preparation for vue3
add eslint rule
Updates the requirements on [cryptography](https://github.com/pyca/cryptography) to permit the latest version.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@42.0.1...42.0.2)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Updates the requirements on [psycopg](https://github.com/psycopg/psycopg) to permit the latest version.
- [Changelog](https://github.com/psycopg/psycopg/blob/master/docs/news.rst)
- [Commits](psycopg/psycopg@3.1.17...3.1.18)

---
updated-dependencies:
- dependency-name: psycopg
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterthomassen peterthomassen merged commit 09955a6 into desec-io:main Feb 5, 2024
5 checks passed
@Rotzbua Rotzbua deleted the chore_migrate_css_deep branch May 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants