adding economic calendar

[ashkan-deriv]

Changes:

• ...

Type of change

• [ x ] New feature

[review-deriv]

AI Review (AI review can be wrong. Do not use it as the only source of feedback)

🔴 Critical Issues

No critical security vulnerabilities or major logical flaws were found in the provided code snippet.

---

🟡 Potential Concerns

1. Edge Case in Date Formatting

• Problem: The formatDate function does not handle invalid or unexpected date strings. If dateString is invalid, new Date(dateString) may result in an Invalid Date, and calling toLocaleDateString on it may not produce the desired output.

• Potential Impact: This could lead to displaying incorrect date information or 'Invalid Date' in the UI, negatively affecting the user experience.

• Suggestion: Validate the date object before formatting and handle invalid dates gracefully, perhaps by returning a placeholder like '-'.

• Fix:

  const formatDate = (dateString) => {
      if (!dateString) return '-';
      const date = new Date(dateString);
      if (isNaN(date.getTime())) return '-'; // Handle invalid date
      return date.toLocaleDateString('en-GB', {
          day: '2-digit',
          month: '2-digit',
          year: 'numeric',
      });
  };

2. Handling of Empty or Unexpected Data

• Problem: The getDisplayValue function assumes that if field is an object with a display_value, that is the correct value to display. There may be cases where field is an object but does not have display_value, or display_value is not a string.

• Potential Impact: Could display 'undefined' or '[object Object]' in the UI if field is an object without a proper display_value. This affects the user experience by showing confusing or incorrect data.

• Suggestion: Add additional checks to ensure that field.display_value exists and is a string before returning it.

• Fix:

  const getDisplayValue = (field) => {
      if (!field) return '-';
      if (typeof field === 'object' && 'display_value' in field) {
          return field.display_value.toString();
      }
      return field.toString();
  };

3. Potential Unhandled Errors in Data Fetching

• Problem: If the BinarySocket.send operation fails due to network issues or server errors, and the .catch block is executed, the user is not notified; they're left looking at

[github-actions]

Name	Result
Build status	Failed ❌
Action URL	Visit Action