Fix syntax for string literal in square brackets #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since https://docs.scala-lang.org/sips/42.type.html which is implemented in scala 2.13 and in scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file.
|
@derekwyatt Are you still maintaining and accepting PRs in this repository? Or should one submit such fixes directly to the vim repository? |
eejbyfeldt
added a commit
to eejbyfeldt/vim
that referenced
this pull request
Sep 10, 2023
Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed.
chrisbra
pushed a commit
to vim/vim
that referenced
this pull request
Sep 10, 2023
…13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: #9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. Signed-off-by: Christian Brabandt <[email protected]>
clason
added a commit
to clason/neovim
that referenced
this pull request
Sep 10, 2023
runtime(scala): Fix Scala highlighting string literal as type param (vim/vim#13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim/vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. vim/vim@0661033 Co-authored-by: Emil Ejbyfeldt <[email protected]>
clason
added a commit
to neovim/neovim
that referenced
this pull request
Sep 11, 2023
runtime(scala): Fix Scala highlighting string literal as type param (vim/vim#13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim/vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. vim/vim@0661033 Co-authored-by: Emil Ejbyfeldt <[email protected]>
glepnir
pushed a commit
to glepnir/neovim
that referenced
this pull request
Sep 14, 2023
runtime(scala): Fix Scala highlighting string literal as type param (vim/vim#13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim/vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. vim/vim@0661033 Co-authored-by: Emil Ejbyfeldt <[email protected]>
ur4ltz
pushed a commit
to ur4ltz/neovim-1
that referenced
this pull request
Sep 15, 2023
runtime(scala): Fix Scala highlighting string literal as type param (vim/vim#13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim/vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. vim/vim@0661033 Co-authored-by: Emil Ejbyfeldt <[email protected]>
dundargoc
pushed a commit
to dundargoc/neovim
that referenced
this pull request
Sep 27, 2023
runtime(scala): Fix Scala highlighting string literal as type param (vim/vim#13070) Since https://docs.scala-lang.org/sips/42.type.html which is implemented in Scala 2.13 and in Scala 3 it possible to use string literals as singleton types. So code like ``` someFunc["abc"] ``` is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed `(` in the string it breaks the formating in the rest of the file. I also submitted this patch to the mentioned project for this runtime file: derekwyatt/vim-scala#173 But there are no commits there over the last 2 years and no response in the week since I created it. Also the last change to the Scala syntax file: vim/vim#9594 is yet to be backported to that repo. Therefore I am opening this PR as well to get some feedback on how to proceed to get this fixed. vim/vim@0661033 Co-authored-by: Emil Ejbyfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://docs.scala-lang.org/sips/42.type.html which is implemented in scala 2.13 and in scala 3 it possible to use string literals as singleton types. So code like
is valid. Currently this code is not hightlighted correctly and worse if there is an unclosed
(in the string it breaks the formating in the rest of the file.