-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two Fixes: Components Style, LiveScript #505
Conversation
is there a reason so many of the commits in master are included in your PR? makes it very difficult to evaluate your changes. |
No, I have no idea why this happened. All I keep doing is
But you can click on my two commits at the top to see the changes, they are very simple, just adding a few lines of code. It shouldn't have affected all the other commits. |
3baf3b6
to
4fa6e7c
Compare
Ok, finally fixed it with --force. The last |
"Separate style files" for components doesn't fit for stylus. We've discussed the issue somewhere. |
I've found. It's here - #477 |
I see, I missed that plugin (I am using sass, btw). But if you cannot merge it, shouldn't the docs be updated then? See http://derbyjs.com/docs/derby-0.6/components/structure, it mentions |
1b00a7c
to
65858f3
Compare
aa3f9a1
to
5eb3ff9
Compare
5eb3ff9
to
3f5430b
Compare
5d8bca6
to
eb01287
Compare
- typeof null === 'object', so check for null - put LiveScript detection into its own function
specify the style file with component.prototype.style
usage: MyComponent.prototype.name = 'maincomponent' MyComponent.prototype.components = [require('subcomponent')] result: maincomponent maincomponent:subcomponent
eb01287
to
04e0324
Compare
I close this pr since it used the master branch, which was a bad idea, and there is no way to change the branch. |
Hi Nate,
see the two commits for details. I thought components were supposed to load their styles, but they don't. This is now fixed. Also, I am writing my code in LiveScript, however, components didn't work without this patch.
Cheers, Michael