Fix static build failing due to view caching (#16)

* Ensure listeners not added and viewcache is initilized when building static assets * Do not register app if not static build
derbyjs · Apr 25, 2023 · 112067b · 112067b
1 parent 9aaea6e
commit 112067b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/lib/DerbyViewPlugin.js b/lib/DerbyViewPlugin.js
@@ -24,6 +24,10 @@ DerbyViewsPlugin.prototype.apply = function(compiler) {
       virtualViewFilesInitialized = true;
       Object.entries(appNameToPath).forEach(([appName, requirePath]) => {
         const appPath = require.resolve(requirePath, { paths: [rootPath] });
+        if (!process.env.DERBY_HMR) {
+          const app = require(appPath);
+          viewCache.registerApp(app);
+        }
         function updateVirtualViewsFile() {
           const viewSource = viewCache.getViewsSource(appPath);
           if (viewSource) {
@@ -33,7 +37,9 @@ DerbyViewsPlugin.prototype.apply = function(compiler) {
           }
         }
         updateVirtualViewsFile();
-        viewCache.addViewUpdateListener(appPath, updateVirtualViewsFile);
+        if (process.env.DERBY_HMR) {
+          viewCache.addViewUpdateListener(appPath, updateVirtualViewsFile);
+        }
       });
     }
 

diff --git a/lib/plugin.js b/lib/plugin.js
@@ -28,10 +28,12 @@ function pluginForAppInstance(app) {
     }
   }
 
-  viewCache.registerApp(app);
-  app._updateScriptViews = function() {
-    viewCache.refreshApp(this);
-  };
+  if (process.env.DERBY_HMR) {
+    viewCache.registerApp(app);
+    app._updateScriptViews = function() {
+      viewCache.refreshApp(this);
+    };
+  }
 
   function middlewareAssets(page) {
     const { devMiddleware } = page.res.locals.webpack;