-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manage bootstrap using npm #23
base: master
Are you sure you want to change the base?
Conversation
This effectively reverts the approach of af8c522 keeping the spirit I see behind d2823ab that is, managing twbs using npm will be easier to maintain. Redistributing the minified file prevents another repo-moved fiasco like derbyjs#16, while listing bootstrap as a devDependency means that developers will be able to peruse the same version of the unminifed source without it being checked in to this repository.
This is a much smaller change than it appears due to 3 of the files in |
Good idea using npm to manage installing. I'd include all of the css and less files so that people can require them from within d-bootstrap. It should actually be optional whether or not you want to include the css styles, since you might use a custom compiled version of bootstrap from http://getbootstrap.com/customize/ or you might prefer to require the less files for more flexibility. Perhaps the default should change to not include any styles, and there should be options to include the main styles and the theme styles. |
I'm under the impression that bootstrap is not distributed as an npm package, but is only distributed as a bower package, despite the package.json in the repo. I chose to fetch it directly with git rather than add an additional dependency on bower. Now that I think about this, npm should be using github's release url for the tarball. The tarball is currently 5.6MB. Since it looks like the less compiler will be packaged with Derby for now, perhaps it would be better for loadStyles to just be passed the less. In combination with a config object for modifying paths, this would be the most flexible. |
I'd prefer to include styles by default, but agree it is important for customization to be possible. |
Using the less directly seems most flexible from a customization perspective, but I'll wait on making that change until derbyjs/derby#388 is reviewed. |
hmm, while grabbing this over git worked fine the npm docs appear to indicate that anything in |
finished reading npm and found bundledDependencies which solves the problem |
@wenzowski @nateps |
This effectively reverts the approach of af8c522
keeping the spirit I see behind d2823ab
that is, managing twbs using npm will be
easier to maintain.
Redistributing the minified file prevents
another repo-moved fiasco like #16, while listing
bootstrap as a devDependency means that developers
will be able to peruse the same version of the
unminifed source without it being checked in to
this repository.