Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replaced test-listen with async-listen #920

Merged
merged 1 commit into from
Nov 7, 2023
Merged

chore: replaced test-listen with async-listen #920

merged 1 commit into from
Nov 7, 2023

Conversation

chrisrice202
Copy link
Contributor

Closes: #884

@chrisrice202 chrisrice202 requested a review from a team as a code owner November 7, 2023 01:04
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chrisrice202 chrisrice202 force-pushed the chore/async-listen/tech-debt branch from deb742a to d9f91d3 Compare November 7, 2023 01:15
straker
straker approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@straker straker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr!

Approved for security (manually verified that the async-listen entry in the package-lock.json matches what it should)

@straker straker merged commit 30af456 into dequelabs:develop Nov 7, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testlisten has been deprecated
3 participants
@chrisrice202 @CLAassistant @straker