fix(playwright): skip unloaded iframes

dequelabs · May 13, 2024 · b57bfd0 · b57bfd0
1 parent 8644fbd
commit b57bfd0
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/playwright/package.json b/packages/playwright/package.json
@@ -54,7 +54,7 @@
     "axe-core": "~4.9.0"
   },
   "devDependencies": {
-    "@playwright/test": "^1.34.3",
+    "@playwright/test": "^1.44.0",
     "@types/chai": "^4.3.3",
     "@types/express": "^4.17.14",
     "@types/mocha": "^10.0.0",

diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts
@@ -185,7 +185,14 @@ export default class AxeBuilder {
 
   private async inject(frames: Frame[]): Promise<void> {
     for (const iframe of frames) {
-      await iframe.evaluate(await this.script());
+      const race = new Promise((_, reject) => {
+        setTimeout(() => {
+          reject(new Error('Script Timeout'));
+        }, 1000);
+      });
+      const evaluate = iframe.evaluate(this.script());
+
+      await Promise.race([evaluate, race]);
       await iframe.evaluate(await this.axeConfigure());
     }
   }

diff --git a/packages/playwright/test/axe-playwright.spec.ts b/packages/playwright/test/axe-playwright.spec.ts
@@ -447,7 +447,12 @@ describe('@axe-core/playwright', () => {
         .analyze();
 
       assert.equal(res?.status(), 200);
-      assert.lengthOf(results.incomplete, 0);
+      assert.equal(results.incomplete[0].id, 'frame-tested');
+      assert.lengthOf(results.incomplete[0].nodes, 1);
+      assert.deepEqual(results.incomplete[0].nodes[0].target, [
+        '#ifr-lazy',
+        '#lazy-iframe'
+      ]);
       assert.equal(results.violations[0].id, 'label');
       assert.lengthOf(results.violations[0].nodes, 1);
       assert.deepEqual(results.violations[0].nodes[0].target, [