Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added artisan:bugsnag:deploy task #3557

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrecolza
Copy link

Added task to notify BugSnag of releases using the Laravel Artisan console.

  • Bug fix #…?

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

BugSnag provides a Laravel Artisan bugsnag:deploy command to report releases. This PR adds a task in contrib/bugsnag.php to allow use that command when deploying.

Note: I required the Laravel recipe to allow the use of artisan function, not sure if is the right way.

This is related to #3402

Added task to notify BugSnag of releases using the Laravel Artisan console.
@antonmedv
Copy link
Member

Let’s put in the laravel recipe.

@andrecolza
Copy link
Author

@antonmedv Ok, I can open a second PR to put the new task it in the Laravel recipe, but I think it shouldn't be placed there: the Laravel recipe only contains tasks related to first-party commands, while this is a command provided by a third-party package (BugSnag).

The only other case I've found in Deployer is about Statamic, which has its own recipe that extends the Laravel recipe.
Are you sure you prefer this task to be added in the Laravel recipe?

@antonmedv
Copy link
Member

antonmedv commented Mar 31, 2023

Definitely not importing laravel in contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants