Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpd-dashboard theme changed, file editor added, screenshots #13

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

moorthi07
Copy link
Member

dpd-dashboard theme changed, file editor added, screenshots.
This leads dpd-dashboard a full scale Deployd IDE

Note: The merge diff shows lots of differences - mostly its the visualcode editor formatting for js files.
For example, ( a comma - ',' in the prefix is moved to end of line)
, ejs = require('ejs')

  • , loadTypes = require('deployd/lib/type-loader')
  • , async = require('async');

is corrected to,
ejs = require('ejs'),

  • loadTypes = require('deployd/lib/type-loader'),
  • async = require('async'),
  • fileedit = require('./marscode');

@andreialecu
Copy link
Contributor

I would suggest publishing this as a new separate fork, maybe name it dpd-studio.

The scope of the changes here are too big for dpd-dashboard. This is not something most people will need.

@moorthi07
Copy link
Member Author

@andreialecu can you be more specific on which feature you think not in the scope of dashboard. Because we have been discussing more than a year to revamp and redo dpd-dashboard. This PR has made it look better.
Even to make other dashboard packages to be installed, dashboard should support a 'plugin' model.

One more minor fix done in this PR is, 'Add resource dialogbox placeholder name jumping issue'

@moorthi07
Copy link
Member Author

The file editor is pulled out now. So, new theme for dashboard and a fix for 'add collection' dialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants