Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#16 global require #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue#16 global require #24

wants to merge 4 commits into from

Conversation

Kapnobatai3434
Copy link
Contributor

Fixed eslint errors for 'global-require' rule

Description

2 minor chenges in keygen.js and showkey.js. Placed require() outside function body

Motivation and Context

It was requested by NicolasRitouet

#16

How Has This Been Tested?

npm run test command

the code was tested using jest

Screenshots (if appropriate):

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant