fix release workflow #168
Merged
fix release workflow #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Aug 16, 2023
jeffwidman
approved these changes
Aug 16, 2023
|
Curious: did it always have to be specified or is it because 1.21 is now shipped as 1.21.0 vs previously the first release was 1.20 and only the second was 1.20.1? This was a change that upstream go project made. |
|
Looks like 1.19 didn't need a patch specified. Not a big deal, I suppose we should try making releases when bumping the version since they like to change things on us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs the patch specified because it builds a URL with the version. It was removed in #164.