Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Virtus with Vets::Model on AVS #18680

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Replace Virtus with Vets::Model on AVS #18680

wants to merge 8 commits into from
+90 −92

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented Sep 30, 2024 •
edited
Loading

Summary

  • Virtus is discontinued and needs to be removed.
  • Replace Virtus models with Vets::Model
  • Vets::Model needed a minor update to handle the base case and AVS case
  • Another minor update to the spec was required to make the keys symbols

Related issue(s)

Testing done

  • manually comparing the previous and new AfterVisitSummary object

Acceptance criteria

  • virtus models are now subclasses of Vets::Model
  • model(s) don't use the virtus gem

@stevenjcumming stevenjcumming self-assigned this Sep 30, 2024
@stevenjcumming stevenjcumming changed the title refactor avs_controller & implement vets::model Replace Virtus with Vets::Model on AVS Sep 30, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-avs-vets-model/main/main September 30, 2024 16:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-avs-vets-model/main/main September 30, 2024 17:24 Inactive
@stevenjcumming stevenjcumming marked this pull request as ready for review September 30, 2024 17:58
@stevenjcumming stevenjcumming requested review from a team as code owners September 30, 2024 17:58
@stevenjcumming
Copy link
Contributor Author

@acrollet would you (or someone on your team) mind reviewing this PR when you have a chance?

@va-vfs-bot va-vfs-bot temporarily deployed to sjc-avs-vets-model/main/main September 30, 2024 18:06 Inactive
@RachalCassity RachalCassity self-assigned this Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Backend-review-group approval confirmed.

@acrollet
Copy link
Contributor

acrollet commented Oct 4, 2024

This is still on my list to review, I've been having issues with socks and unable to view the review instance.

@acrollet
Copy link
Contributor

Updating against master for RI rebuild

@acrollet
Copy link
Contributor

SOCKs are fixed, now waiting on a RI auth issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachalCassity RachalCassity RachalCassity approved these changes

Assignees

@RachalCassity RachalCassity

@stevenjcumming stevenjcumming

Labels
ready-for-backend-review require-backend-approval test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenjcumming @acrollet @RachalCassity @va-vfs-bot