Merge branch 'master' into 9774-documents

.github/CODEOWNERS

@@ -608,7 +608,6 @@ app/sidekiq/cypress_viewport_updater @department-of-veterans-affairs/backend-rev
 app/sidekiq/decision_review @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/decision_review/form4142_submit.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/decision_review/submit_upload.rb @department-of-veterans-affairs/benefits-decision-reviews-be @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-app/sidekiq/direct_deposit_email_job.rb @department-of-veterans-affairs/vfs-authenticated-experience-backend @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/education_form @department-of-veterans-affairs/my-education-benefits @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/education_form/templates/10203.erb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/education_form/templates/1990.erb @department-of-veterans-affairs/govcio-vfep-codereviewers @department-of-veterans-affairs/backend-review-group
@@ -650,7 +649,6 @@ app/sidekiq/pager_duty @department-of-veterans-affairs/va-api-engineers @departm
 app/sidekiq/preneeds @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/schema_contract @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/sign_in @department-of-veterans-affairs/octo-identity
-app/sidekiq/structured_data/process_data_job.rb @department-of-veterans-affairs/benefits-non-disability @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 app/sidekiq/terms_of_use @department-of-veterans-affairs/octo-identity
 app/sidekiq/test_user_dashboard @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/qa-standards @department-of-veterans-affairs/backend-review-group
 app/sidekiq/test_user_dashboard/daily_maintenance.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/qa-standards @department-of-veterans-affairs/backend-review-group
@@ -796,6 +794,7 @@ docs/deployment @department-of-veterans-affairs/va-api-engineers @department-of-
 docs/deployment/information.md @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 docs/HISTORY.md @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 docs/index.md @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+docs/modules @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 docs/setup/betamocks.md @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 docs/setup/binstubs.md @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 docs/setup/docker.md @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/va-api-engineers
@@ -1005,6 +1004,7 @@ modules/appeals_api @department-of-veterans-affairs/lighthouse-banana-peels @dep
 modules/apps_api @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/lighthouse-pivot
 modules/ask_va_api @department-of-veterans-affairs/ask-va-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 modules/avs @department-of-veterans-affairs/after-visit-summary @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
+modules/burials @department-of-veterans-affairs/pension-and-burials @department-of-veterans-affairs/backend-review-group
 modules/check_in @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/vsa-healthcare-health-quest-1-backend @department-of-veterans-affairs/patient-check-in @department-of-veterans-affairs/backend-review-group
 modules/claims_api @department-of-veterans-affairs/lighthouse-dash
 modules/covid_research @department-of-veterans-affairs/long-covid
@@ -1017,6 +1017,7 @@ modules/income_limits @department-of-veterans-affairs/vfs-public-websites-fronte
 modules/ivc_champva @department-of-veterans-affairs/champva-engineering @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 modules/meb_api @department-of-veterans-affairs/my-education-benefits
 modules/mobile @department-of-veterans-affairs/mobile-api-team
+modules/mobile/app/assets/translations @department-of-veterans-affairs/flagship-mobile-content @department-of-veterans-affairs/backend-review-group
 modules/mocked_authentication @department-of-veterans-affairs/octo-identity
 modules/my_health @department-of-veterans-affairs/vfs-mhv-secure-messaging @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 modules/representation_management @department-of-veterans-affairs/backend-review-group @department-of-veterans-affairs/accredited-representation-management
@@ -1351,7 +1352,6 @@ spec/sidekiq/schema_contract @department-of-veterans-affairs/va-api-engineers @d
 spec/sidekiq/sidekiq_stats_job_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/sign_in @department-of-veterans-affairs/octo-identity
 spec/sidekiq/sign_in/delete_expired_sessions_job_spec.rb @department-of-veterans-affairs/octo-identity
-spec/sidekiq/structured_data/process_data_job_spec.rb @department-of-veterans-affairs/benefits-non-disability @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/terms_of_use @department-of-veterans-affairs/octo-identity
 spec/sidekiq/test_user_dashboard @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/qa-standards @department-of-veterans-affairs/backend-review-group
 spec/sidekiq/transactional_email_analytics_job_spec.rb @department-of-veterans-affairs/backend-review-group
@@ -1671,7 +1671,6 @@ spec/requests/v0/appointments_spec.rb @department-of-veterans-affairs/vfs-vaos @
 spec/requests/v0/messaging/health/messages/attachments_spec.rb @department-of-veterans-affairs/vfs-mhv-secure-messaging @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/requests/authentication/standard_authentication_spec.rb @department-of-veterans-affairs/octo-identity
 spec/requests/v0/backend_status_spec.rb @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
-spec/requests/v0/burial_claims_spec.rb @department-of-veterans-affairs/mbs-core-team @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/requests/v0/caregivers_assistance_claims_spec.rb @department-of-veterans-affairs/vfs-10-10 @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/requests/v0/claim_documents_spec.rb @department-of-veterans-affairs/Disability-Experience @department-of-veterans-affairs/va-api-engineers @department-of-veterans-affairs/backend-review-group
 spec/requests/v0/debts_spec.rb @department-of-veterans-affairs/vsa-debt-resolution @department-of-veterans-affairs/backend-review-group

.github/workflows/be_review_prs.yml

@@ -57,8 +57,16 @@ jobs:
  if: contains(github.event.pull_request.labels.*.name, 'require-backend-approval')
  id: verify_approval
  run: |
- BACKEND_REVIEWERS=$(echo '${{ steps.get_team_members.outputs.data }}' | jq -r '.[].login' | tr '\n' '|' | sed 's/|$//')
- APPROVALS=$(echo '${{ steps.check_backend_review_group_approval_status.outputs.data }}' | jq -r '.[] | select(.state == "APPROVED") | .user.login' | grep -iE "$BACKEND_REVIEWERS" | wc -l)
+ BACKEND_REVIEWERS=$(cat <<'EOF' | jq -r '.[].login' | tr '\n' '|' | sed 's/|$//'
+ ${{ steps.get_team_members.outputs.data }}
+ EOF
+ )
+
+ APPROVALS=$(cat <<'EOF' | jq -r '.[] | select(.state == "APPROVED") | .user.login' | grep -iE "$BACKEND_REVIEWERS" | wc -l
+ ${{ steps.check_backend_review_group_approval_status.outputs.data }}
+ EOF
+ )
+
  echo "Number of backend-review-group approvals: $APPROVALS"
  if [ "$APPROVALS" -eq 0 ]; then
  echo "approval_status=required" >> $GITHUB_OUTPUT

.github/workflows/check_codeowners.yml

@@ -49,7 +49,7 @@ jobs:
 
  - name: Respond to PR if check CODEOWNERS exists for new files fails
  if: ${{ failure() }}
- uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 # v2.5.0
+ uses: thollander/actions-comment-pull-request@e2c37e53a7d2227b61585343765f73a9ca57eda9 # v3.0.0
  with:
  message: 'Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: ${{ env.offending_file }}'
  GITHUB_TOKEN: ${{ env.VA_VSP_BOT_GITHUB_TOKEN }}
@@ -109,7 +109,7 @@ jobs:
 
  - name: Respond to PR if check CODEOWNERS exists for deleted files fails
  if: ${{ failure() }}
- uses: thollander/actions-comment-pull-request@fabd468d3a1a0b97feee5f6b9e499eab0dd903f6 # v2.5.0
+ uses: thollander/actions-comment-pull-request@e2c37e53a7d2227b61585343765f73a9ca57eda9 # v3.0.0
  with:
  message: 'Error: A file (or its parent directories) was deleted but its reference still exists in CODEOWNERS. Please update the .github/CODEOWNERS file and delete the entry for the Offending file: ${{ env.offending_file }}'
  GITHUB_TOKEN: ${{ env.VA_VSP_BOT_GITHUB_TOKEN }}

.github/workflows/ready_for_review.yml

@@ -25,6 +25,7 @@ jobs:
  ssm_parameter: /devops/VA_VSP_BOT_GITHUB_TOKEN
  env_variable_name: VA_VSP_BOT_GITHUB_TOKEN
 
+ # If no failures, no_failures=true
  - name: Audit PR Labels
  id: audit_pr_labels
  if: |
@@ -36,13 +37,15 @@ jobs:
  run: |
  echo "no_failures=true" >> $GITHUB_OUTPUT
 
+ # If test-passing label is present, ready_for_review=true
  - name: Audit Test Passing Label
  id: audit_passing_labels
  if: |
  contains(github.event.pull_request.labels.*.name, 'test-passing')
  run: |
  echo "ready_for_review=true" >> $GITHUB_OUTPUT
 
+ # If require-backend-approval label is present, get reviews
  - name: Check backend-review-group approval status
  if: contains(github.event.pull_request.labels.*.name, 'require-backend-approval')
  id: check_backend_review_group_approval_status
@@ -52,6 +55,7 @@ jobs:
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
+ #
  - name: Get backend-review-group members
  if: contains(github.event.pull_request.labels.*.name, 'require-backend-approval')
  id: get_team_members
@@ -65,8 +69,16 @@ jobs:
  if: contains(github.event.pull_request.labels.*.name, 'require-backend-approval')
  id: verify_approval
  run: |
- BACKEND_REVIEWERS=$(echo '${{ steps.get_team_members.outputs.data }}' | jq -r '.[].login' | tr '\n' '|' | sed 's/|$//')
- APPROVALS=$(echo '${{ steps.check_backend_review_group_approval_status.outputs.data }}' | jq -r '.[] | select(.state == "APPROVED") | .user.login' | grep -iE "$BACKEND_REVIEWERS" | wc -l)
+ BACKEND_REVIEWERS=$(cat <<'EOF' | jq -r '.[].login' | tr '\n' '|' | sed 's/|$//'
+ ${{ steps.get_team_members.outputs.data }}
+ EOF
+ )
+
+ APPROVALS=$(cat <<'EOF' | jq -r '.[] | select(.state == "APPROVED") | .user.login' | grep -iE "$BACKEND_REVIEWERS" | wc -l
+ ${{ steps.check_backend_review_group_approval_status.outputs.data }}
+ EOF
+ )
+
  echo "Number of backend-review-group approvals: $APPROVALS"
  if [ "$APPROVALS" -eq 0 ]; then
  echo "approval_status=required" >> $GITHUB_OUTPUT

Gemfile

@@ -11,6 +11,7 @@ path 'modules' do
  gem 'apps_api'
  gem 'ask_va_api'
  gem 'avs'
+ gem 'burials'
  gem 'check_in'
  gem 'claims_api'
  gem 'covid_research'
@@ -137,6 +138,7 @@ gem 'rails-session_cookie'
 gem 'redis'
 gem 'redis-namespace'
 gem 'request_store'
+gem 'require_all'
 gem 'restforce'
 gem 'rgeo-geojson'
 gem 'roo'

Gemfile.lock

@@ -93,6 +93,7 @@ PATH
  sidekiq
  ask_va_api (0.1.0)
  avs (0.1.0)
+ burials (0.1.0)
  check_in (0.1.0)
  claims_api (0.0.1)
  dry-schema
@@ -152,76 +153,76 @@ GEM
  Ascii85 (1.1.0)
  aasm (5.5.0)
  concurrent-ruby (~> 1.0)
- actioncable (7.1.3.4)
- actionpack (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actioncable (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  nio4r (~> 2.0)
  websocket-driver (>= 0.6.1)
  zeitwerk (~> 2.6)
- actionmailbox (7.1.3.4)
- actionpack (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionmailbox (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ activejob (= 7.1.4.1)
+ activerecord (= 7.1.4.1)
+ activestorage (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  mail (>= 2.7.1)
  net-imap
  net-pop
  net-smtp
- actionmailer (7.1.3.4)
- actionpack (= 7.1.3.4)
- actionview (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionmailer (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ actionview (= 7.1.4.1)
+ activejob (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  mail (~> 2.5, >= 2.5.4)
  net-imap
  net-pop
  net-smtp
  rails-dom-testing (~> 2.2)
- actionpack (7.1.3.4)
- actionview (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionpack (7.1.4.1)
+ actionview (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  nokogiri (>= 1.8.5)
  racc
  rack (>= 2.2.4)
  rack-session (>= 1.0.1)
  rack-test (>= 0.6.3)
  rails-dom-testing (~> 2.2)
  rails-html-sanitizer (~> 1.6)
- actiontext (7.1.3.4)
- actionpack (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ actiontext (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ activerecord (= 7.1.4.1)
+ activestorage (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  globalid (>= 0.6.0)
  nokogiri (>= 1.8.5)
- actionview (7.1.3.4)
- activesupport (= 7.1.3.4)
+ actionview (7.1.4.1)
+ activesupport (= 7.1.4.1)
  builder (~> 3.1)
  erubi (~> 1.11)
  rails-dom-testing (~> 2.2)
  rails-html-sanitizer (~> 1.6)
- activejob (7.1.3.4)
- activesupport (= 7.1.3.4)
+ activejob (7.1.4.1)
+ activesupport (= 7.1.4.1)
  globalid (>= 0.3.6)
- activemodel (7.1.3.4)
- activesupport (= 7.1.3.4)
- activerecord (7.1.3.4)
- activemodel (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ activemodel (7.1.4.1)
+ activesupport (= 7.1.4.1)
+ activerecord (7.1.4.1)
+ activemodel (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  timeout (>= 0.4.0)
  activerecord-import (1.7.0)
  activerecord (>= 4.2)
  activerecord-postgis-adapter (9.0.2)
  activerecord (~> 7.1.0)
  rgeo-activerecord (~> 7.0.0)
- activestorage (7.1.3.4)
- actionpack (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ activestorage (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ activejob (= 7.1.4.1)
+ activerecord (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  marcel (~> 1.0)
- activesupport (7.1.3.4)
+ activesupport (7.1.4.1)
  base64
  bigdecimal
  concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -797,20 +798,20 @@ GEM
  rackup (1.0.0)
  rack (< 3)
  webrick
- rails (7.1.3.4)
- actioncable (= 7.1.3.4)
- actionmailbox (= 7.1.3.4)
- actionmailer (= 7.1.3.4)
- actionpack (= 7.1.3.4)
- actiontext (= 7.1.3.4)
- actionview (= 7.1.3.4)
- activejob (= 7.1.3.4)
- activemodel (= 7.1.3.4)
- activerecord (= 7.1.3.4)
- activestorage (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ rails (7.1.4.1)
+ actioncable (= 7.1.4.1)
+ actionmailbox (= 7.1.4.1)
+ actionmailer (= 7.1.4.1)
+ actionpack (= 7.1.4.1)
+ actiontext (= 7.1.4.1)
+ actionview (= 7.1.4.1)
+ activejob (= 7.1.4.1)
+ activemodel (= 7.1.4.1)
+ activerecord (= 7.1.4.1)
+ activestorage (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  bundler (>= 1.15.0)
- railties (= 7.1.3.4)
+ railties (= 7.1.4.1)
  rails-dom-testing (2.2.0)
  activesupport (>= 5.0.0)
  minitest
@@ -824,9 +825,9 @@ GEM
  rack
  railties (>= 5.1)
  semantic_logger (~> 4.16)
- railties (7.1.3.4)
- actionpack (= 7.1.3.4)
- activesupport (= 7.1.3.4)
+ railties (7.1.4.1)
+ actionpack (= 7.1.4.1)
+ activesupport (= 7.1.4.1)
  irb
  rackup (>= 1.0.0)
  rake (>= 12.2)
@@ -855,6 +856,7 @@ GEM
  uber (< 0.2.0)
  request_store (1.7.0)
  rack (>= 1.4)
+ require_all (3.0.0)
  restforce (7.5.0)
  faraday (>= 1.1.0, < 2.12.0)
  faraday-follow_redirects (<= 0.3.0, < 1.0.0)
@@ -919,7 +921,7 @@ GEM
  actionpack (>= 5.2, < 8.0)
  railties (>= 5.2, < 8.0)
  rtesseract (3.1.3)
- rubocop (1.66.1)
+ rubocop (1.67.0)
  json (~> 2.3)
  language_server-protocol (>= 3.17.0)
  parallel (~> 1.10)
@@ -1128,6 +1130,7 @@ DEPENDENCIES
  brakeman
  breakers
  bundler-audit
+ burials!
  byebug
  carrierwave
  carrierwave-aws
@@ -1246,6 +1249,7 @@ DEPENDENCIES
  redis-namespace
  representation_management!
  request_store
+ require_all
  restforce
  rgeo-geojson
  roo