VACMS 19273 - menu exception manila and add to menus download

[eselkin]

Summary

• Adds manila-va-clinic to menu download, but because manila-va-clinic has no parent, exception is created to allow menus to be created for it.
• Sitewide team (we own facility pages)

Related issue(s)

• Add Manila Menu to Menu list in Content Build (launch blocking) va.gov-cms#19273

Testing done

• Manual testing by numerous people for existence of menus, breadcrumbs accessibility, and get updates box correctness

Screenshots

Manila VAMC main page

Manila VAMC main page - showing breadcrumb to current page content

Manila VAMC main page - showing link to About us nested page

Manila VAMC About Us page - with breadcrumb back to Manila VAMC (not system)

Manila VAMC main page - Get Updates content

What areas of the site does it impact?

Manila VAMC page

Acceptance criteria

• Manila menu appears on the left sidenav of Manila VA Clinic pages based on Section
• Preview works on Manila pages
• Manila pages build successfully

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Because of the status of tugboats rebuilding every night and resetting, you'll have to test locally from a tugboat with Manila VAMC (not the system) published, and the Manila About Us page published and make sure the parent in the menu is pointing to the About Manila VAMC <nolink> menu section.

To publish VAMC
Go to:
/node/1059/edit
Changes Save as to published and add some text in textbox and click save

To publish About us page and make sure it's in the correct location go to
/manila-va-clinic/about-us
then edit
then under menu settings on the right, choose:
Parent link to be:

and keep the Alias URL the same.
Change save as to: published
add some text in the text box and save

Point your content build to the tugboat to build with:
yarn build --use-cached-assets --pull-drupal --drupal-address=https://tugboatmainaddress
and wait the 900000000 minutes

[eselkin]

Manila VAMC has no parent system published so the path is empty but it still points somewhere (to itself as the Clinic/System)

[randimays]

@eselkin Working on setting up a Tugboat to test.

you'll have to test locally from a tugboat with Manila VAMC (not the system) published

Does this mean I need to publish the Manila VAMC (VAMC Facility)?

[eselkin]

Yes. Publish the facility. Not the VAMC System with the same name.

[jilladams]

(To match what will happen in Prod, the System should be Published > Archived)

[randimays]

@jilladams

(To match what will happen in Prod, the System should be Published > Archived)

Does this mean the VAMC System should be published, then archived?

[randimays]

@eselkin I don't have the option to select the correct menu in the About page per your instructions:

[jilladams]

@randimays yes: in Prod we are going to Publish and then Archive the Manila VAMC System. It would be best to do that for testing, to make sure that no behavior is negatively impacted by that change, when it happens.

[eselkin]

@randimays Sorry, didn't see the message. So, you can make a <nolink> menu item under Manila VA Clinic or spin up a new tugboat and that should have the right menu structure.

To make a nolink menu item,
go to:
/admin/structure/menu/manage/manila-va-clinic
Click "+ Add link" button at the top
In the title box add something like: About Manila VA Clinic
In the link box add: <nolink>
Make sure Enabled is still checked
In the Parent link section on the right Select

Then go back into the about us page and change the parent link to whatever you called the new nolink menu item under -- Manila VA Clinic

[eselkin]

So the Manila VA System page needs to be published -> archived once only. It's just so that it gets picked up for the Blue box about social links for the VAMC facility page.