Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global | Testing focus style #1418

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Global | Testing focus style #1418

wants to merge 2 commits into from

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Nov 22, 2024

Chromatic

https://1314-test-focus-styles--65a6e2ed2314f7b8f98609d8.chromatic.com

Description

See department-of-veterans-affairs/vets-design-system-documentation#1314

Adding focus style to web components. Note that I did not attempt to modify the minimal header or footer styling.

Update: NOTE changes focus background to our default yellow color, so none of the screenshots currently match

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

focus-link focus-action-link
focus-button focus-button-icon
focus-checkbox focus-radio
focus-memorable-date focus-file
focus-official-banner focus-progress-bar
focus-alert-close focus-maintenance-close
focus-promo-close focus-modal-close

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Mottie Mottie added the major Major change in semantic versioning label Nov 22, 2024
@Mottie Mottie self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant