CSS Library: add feedback-related foreground tokens #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jamigibbs
added
patch
jamigibbs
added
css-library
and removed
patch
jamigibbs
changed the title
jamigibbs
reviewed
Nov 20, 2024
| @@ -267,6 +267,12 @@ | |||
| "vads-color-action-border-base-active-on-dark": { | |||
| "*": { "value": "{uswds-system-color-gray-30}"} | |||
| }, | |||
| "vads-color-feedback-foregound-success-on-dark": { | |||
There was a problem hiding this comment.
I think foregound should be foreground?
danbrady
approved these changes
Nov 21, 2024
2 tasks
|
Hi @narin - I noticed you're adding two new tokens, but I don't see the same tokens for the alternate modes? You're requesting:
Should we also have:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://va-mobile-feedback-colors--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Closes department-of-veterans-affairs/va-mobile-library#541
The VA Mobile DS team would like to add new feedback-related foreground tokens to the system and need 2 new primitive and 2 new semantic tokens added to css-library. This PR:
copy-uswds-color-tokensscript to include the following primitive tokens:QA Checklist
N/A
Screenshots
N/A
Acceptance criteria
N/A
Definition of done