Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @fontsource/inter from 4.5.14 to 5.0.1 #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"license": "MIT",
"dependencies": {
"@babel/preset-typescript": "7.21.4",
"@fontsource/inter": "4.5.14",
"@fontsource/inter": "5.0.1",
"@fontsource/roboto": "4.5.8",
"@khanacademy/simple-markdown": "0.8.6",
"@matrix-org/matrix-sdk-crypto-js": "0.1.0-alpha.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a simple dependency upgrade patch for a JavaScript project. The only change is the version of "@fontsource/inter" was updated from "4.5.14" to "5.0.1". This should be a low-risk change, assuming there are no known breaking changes in version 5.0.1.

Some possible improvements include adding more information about the reasons for the dependency upgrade or specifying any backward compatibility concerns. Additionally, it may be helpful to have a proper versioning strategy in place and consider automated tests to detect any issues that may arise from future dependency upgrades.

Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1230,10 +1230,10 @@
minimatch "^3.1.2"
strip-json-comments "^3.1.1"

"@fontsource/inter@4.5.14":
version "4.5.14"
resolved "https://registry.npmjs.org/@fontsource/inter/-/inter-4.5.14.tgz#3944b809aa7bf27dacd20bdc04a49fb738959724"
integrity sha512-JDC9AocdPLuGsASkvWw9hS5gtHE7K9dOwL98XLrk5yjYqxy4uVnScG58NUvFMJDVJRl/7c8Wnap6PEs+7Zvj1Q==
"@fontsource/inter@5.0.1":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@fontsource/inter/-/inter-5.0.1.tgz#43fd31988734fe3abbe6864923ad43ede34038c2"
integrity sha512-jezFhHp0HcVy2t6M6r89EcxkT30vx0ofGauveQWQ81j70N/wNDYs4zI+sedeend6zF9GXIEqpOTO2D1k7VQX4w==

"@fontsource/[email protected]":
version "4.5.8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code patch appears to be a change in the dependency versions for the "@fontsource/inter" package. The new version "5.0.1" is replacing the old version "4.5.14". The integrity hash has also been updated accordingly.

There do not appear to be any bug risks or issues with this code patch. However, it may be worth checking if this new version of "@fontsource/inter" package introduces any breaking changes or other compatibility issues that could affect the rest of the codebase.

As an improvement suggestion, it may be helpful to include a justification or explanation for why this dependency version change was made. This can help future developers understand the reasoning behind the change and make informed decisions about future updates.

Expand Down