Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(crypto): test timingSafeEqual() in handling DataViews #5268

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 3, 2024

Brings coverage @std/crypto to 100%.

Towards #3713

@iuioiua iuioiua requested a review from kt3k as a code owner July 3, 2024 04:41
@github-actions github-actions bot added the crypto label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (8a96290) to head (a59e0d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5268      +/-   ##
==========================================
+ Coverage   95.69%   95.70%   +0.01%     
==========================================
  Files         459      459              
  Lines       38025    38025              
  Branches     5562     5563       +1     
==========================================
+ Hits        36387    36393       +6     
+ Misses       1597     1591       -6     
  Partials       41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua merged commit 735609e into main Jul 3, 2024
16 checks passed
@iuioiua iuioiua deleted the crypto-tse-dataviews branch July 3, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants