test(assert): add "`assert()` throws if expr is falsy" test #5267

iuioiua · 2024-07-03T04:31:35Z

Mainly so @std/assert reaches 100% coverage.

Towards #3713

codecov · 2024-07-03T04:34:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.70%. Comparing base (1a11b69) to head (6b10839).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5267      +/-   ##
==========================================
+ Coverage   95.66%   95.70%   +0.03%     
==========================================
  Files         459      459              
  Lines       38015    38025      +10     
  Branches     5559     5562       +3     
==========================================
+ Hits        36368    36390      +22     
+ Misses       1606     1594      -12     
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kt3k

LGTM. Nice!

test(assert): add "assert() throws if expr is falsy" test

6b10839

iuioiua requested a review from kt3k as a code owner July 3, 2024 04:31

github-actions bot added the assert label Jul 3, 2024

iuioiua enabled auto-merge (squash) July 3, 2024 04:34

kt3k approved these changes Jul 3, 2024

View reviewed changes

iuioiua merged commit c9a4eff into main Jul 3, 2024
15 checks passed

iuioiua deleted the assert-assert-throws branch July 3, 2024 04:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(assert): add "`assert()` throws if expr is falsy" test #5267

test(assert): add "`assert()` throws if expr is falsy" test #5267

iuioiua commented Jul 3, 2024 •

edited

Loading

codecov bot commented Jul 3, 2024

kt3k left a comment

test(assert): add "assert() throws if expr is falsy" test #5267

test(assert): add "assert() throws if expr is falsy" test #5267

Conversation

iuioiua commented Jul 3, 2024 • edited Loading

codecov bot commented Jul 3, 2024

Codecov Report

kt3k left a comment

Choose a reason for hiding this comment

test(assert): add "`assert()` throws if expr is falsy" test #5267

test(assert): add "`assert()` throws if expr is falsy" test #5267

iuioiua commented Jul 3, 2024 •

edited

Loading